add vtadmin docker image (#10543)#10580
Merged
GuptaManan100 merged 1 commit intovitessio:release-14.0from Jun 27, 2022
Merged
Conversation
* add-vtadmin-docker-image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * env as function, update tests and code Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * feat: fix remaining env usages to be function calls Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin build result in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin web cleaning Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin docker image entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add the possibility to custom vtadmin web port in Docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin docker port Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * set default vtadmin docker user as vitess Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * do not build vtadmin frontend in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * build vtadmin frontend only in vtadmin docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * vtadmin replace sed and custom entrypoint with config.js file Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * remove vitess web files in lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * move vtadmin config into a specific directory Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * restore vtadmin web file in mysql57 lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
deepthi
requested review from
ajm188,
derekperkins,
dkhenry,
doeg,
mattlord,
notfelineit and
rohit-nayak-ps
as code owners
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
deepthi
added
Component: VTAdmin
notfelineit
approved these changes
Jun 26, 2022
L3o-pold
approved these changes
Jun 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport "vtadmin docker image"
Related Issue(s)
#10543
Checklist
Deployment Notes