Skip to content

Remove sharding_column_name and sharding_column_type from vtctld2 #10459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 4 commits into from
Jun 8, 2022
Merged

Remove sharding_column_name and sharding_column_type from vtctld2 #10459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35b7e60
Remove sharding_column_name and sharding_column_type
notfelineit Jun 7, 2022
e29e45a
Run make web_build to compile production files
notfelineit Jun 7, 2022
02be342
Remove vars from test
notfelineit Jun 7, 2022
90ca78d
Remove sharding column type select box test from web test
notfelineit Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions go/test/endtoend/vtctldweb/vtctld_web_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,25 +120,10 @@ func TestCreateKs(t *testing.T) {
err := ele.SendKeys("test_keyspace3")
require.Nil(t, err)
assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-force=false", "test_keyspace3"})

case 1:
err := ele.SendKeys("test_id")
require.Nil(t, err)
assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-sharding_column_name=test_id", "-sharding_column_type=UINT64", "-force=false", "test_keyspace3"})
}
}

dropdown, err := dialog.FindElement(selenium.ByTagName, "p-dropdown")
require.Nil(t, err)

click(t, dropdown)

options, err := dropdown.FindElements(selenium.ByTagName, "li")
require.Nil(t, err)

click(t, options[1])

assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-sharding_column_name=test_id", "-sharding_column_type=BYTES", "-force=false", "test_keyspace3"})
assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-force=false", "test_keyspace3"})

create, err := dialog.FindElement(selenium.ByID, "vt-action")
require.Nil(t, err)
Expand All @@ -157,7 +142,7 @@ func TestCreateKs(t *testing.T) {
require.Nil(t, err)
click(t, menu)

options, err = testKs[2].FindElements(selenium.ByTagName, "li")
options, err := testKs[2].FindElements(selenium.ByTagName, "li")
require.Nil(t, err)
for _, v := range options {
if text(t, v) == "Delete" {
Expand Down
72 changes: 36 additions & 36 deletions go/vt/vtctld/rice-box.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion web/vtctld2/app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
</head>
<body class="flex-column">
<vt-app-root class="flex-column flex-grow">Loading...</vt-app-root>
<script type="text/javascript" src="inline.js"></script><script type="text/javascript" src="styles.38b88af69dfd283498eb.bundle.js"></script><script type="text/javascript" src="main.4f05e5457c6dec67dde5.bundle.js"></script></body>
<script type="text/javascript" src="inline.js"></script><script type="text/javascript" src="styles.38b88af69dfd283498eb.bundle.js"></script><script type="text/javascript" src="main.bbd046af7028149e10ca.bundle.js"></script></body>
</html>
2 changes: 1 addition & 1 deletion web/vtctld2/app/inline.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file removed web/vtctld2/app/main.4f05e5457c6dec67dde5.bundle.js.gz
View file
Open in desktop
Binary file not shown.
86 changes: 43 additions & 43 deletions ...2/app/main.4f05e5457c6dec67dde5.bundle.js → ...2/app/main.bbd046af7028149e10ca.bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added web/vtctld2/app/main.bbd046af7028149e10ca.bundle.js.gz
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions web/vtctld2/app/styles.38b88af69dfd283498eb.bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified web/vtctld2/app/styles.38b88af69dfd283498eb.bundle.js.gz
View file
Open in desktop
Binary file not shown.
Loading