[vtadmin] Add loading placeholder for entity table views + update default redirect to /schemas#10331
Merged
doeg merged 4 commits intovitessio:mainfrom May 18, 2022
Merged
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QueryLoadingPlaceholderloading state to all the entity table views (tablets, clusters, etc.)/tabletsto/schemasQueryLoadingPlaceholderto accept multiplequeries(or, as before, just onequery)Updating the default redirect from
/tabletsto/schemaswas a little feature request from Slack, and it makes sense to me!(I think an even better UX would be to store, say, the user's last browsed entity table view and persist that in local storage, but ofc that's a lot more complicated.)
Since the /schemas view is the slowest of all the views (and for us it's very slow indeed, so #10120 is highly anticipated!) I also took this chance to add
QueryLoadingPlaceholdersince before it was simply blank and looked pretty broken.The only caveat with this PR is that I am stumped as to how to write a good test for QueryLoadingPlaceholder's new
queriesprop in a way that isn't racy. 🤔 🤔 🤔 I know it's bad but... if I could just this once punt on adding that test... 🙈 I would appreciate it. The "failure mode" we'd be testing for, in this case, is that the loading placeholder would be shown when it shouldn't, or not shown when it should; certainly embarrassing but not probably world-ending. (I also tested this a bunch internally!)Before (no spinner) and after (with spinner):
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A