Skip to content

[vtadmin] Tidy up /settings (née /debug) page #10218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doeg merged 3 commits into from
May 5, 2022
Merged

[vtadmin] Tidy up /settings (née /debug) page #10218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afeb799
Tidy up /settings (née /debug) page
doeg May 4, 2022
e422982
Margin nits
doeg May 4, 2022
2378e0d
Rename Debug -> Settings
doeg May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/vtadmin/src/components/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { BrowserRouter as Router, Redirect, Route, Switch } from 'react-router-d

import style from './App.module.scss';
import { Tablets } from './routes/Tablets';
import { Debug } from './routes/Debug';
import { Settings } from './routes/Settings';
import { NavRail } from './NavRail';
import { Error404 } from './routes/Error404';
import { Clusters } from './routes/Clusters';
Expand Down Expand Up @@ -107,8 +107,8 @@ export const App = () => {
<Workflow />
</Route>

<Route path="/debug">
<Debug />
<Route path="/settings">
<Settings />
</Route>

<Redirect exact from="/" to="/tablets" />
Expand Down
1 change: 0 additions & 1 deletion web/vtadmin/src/components/NavRail.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ $navRailHoverTransition: background-color 0.1s ease-in-out;
border-right: solid 1px var(--backgroundSecondaryHighlight);
display: flex;
flex-direction: column;
justify-content: space-between;
height: 100vh;
overflow-y: auto;
}
Expand Down
8 changes: 0 additions & 8 deletions web/vtadmin/src/components/NavRail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,6 @@ export const NavRail = () => {
</li>
</ul>
</div>

<div className={style.footerContainer}>
<ul className={style.navList}>
<li>
<NavRailLink icon={Icons.bug} text="Debug" to="/debug" />
</li>
</ul>
</div>
</div>
);
};
Expand Down
Loading