Skip to content

[vtadmin] Single-component vtadmin#10214

Closed
doeg wants to merge 8 commits intovitessio:mainfrom
tinyspeck:sarabee-one-vtadmin-to-rule-them-all
Closed

[vtadmin] Single-component vtadmin#10214
doeg wants to merge 8 commits intovitessio:mainfrom
tinyspeck:sarabee-one-vtadmin-to-rule-them-all

Conversation

@doeg
Copy link
Copy Markdown
Contributor

@doeg doeg commented May 4, 2022 •
edited
Loading

Description

⚠️ WIP ⚠️

Future work:

  • Add vtadmin to the local example
  • End-to-end vtadmin tests (e.g., Cypress)
  • Better static build generation (e.g., next.js)
  • Better 404 handling based on content-type
  • Add build flag to exclude embedded files for a smaller binary

Related Issue(s)

Closes #10118

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

TODO

@doeg doeg mentioned this pull request May 4, 2022
Merged
3 tasks
doeg added 5 commits May 5, 2022 10:40
@doeg
A first proof-of-concept
4365c25 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Add react-snap to generate index.html for each route
4116b33 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Simplify local example
81eb23a 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Add --http-no-web flag
2a89921 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Generalize vtadmin_web_embed.sh script + add 'make vtadmin_web_embed'…
777b6f7 
… target

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg force-pushed the sarabee-one-vtadmin-to-rule-them-all branch from ad3a5a1 to 777b6f7 Compare May 5, 2022 14:40
@doeg
Commit front-end build to go/vt/vtadmin/web/build, update .gitignore …
05f4421 
…+ .gitattributes

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg mentioned this pull request May 6, 2022
Merged
doeg added 2 commits May 9, 2022 09:38
@doeg
Update vtadmin_web_build CI check to validate embedded files
ff6b36f 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Make CI build step note more descriptive
d9d6d72 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@ajm188 ajm188 mentioned this pull request Jun 5, 2022
Merged
3 tasks
@doeg doeg mentioned this pull request Jun 25, 2022
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2022

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jul 7, 2022
@pbibra pbibra mentioned this pull request Jul 12, 2022
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2022

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jul 15, 2022
@notfelineit notfelineit reopened this Jan 23, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jan 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 24, 2023
@notfelineit notfelineit mentioned this pull request Jan 24, 2023
Closed
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 23, 2023

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Feb 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2023

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 will be requested when the pull request is marked ready for review beingnoble03 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Component: VTAdmin VTadmin interface Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vtadmin] Unify vtadmin-web + vtadmin-api into a single vtadmin component, by default

3 participants

@doeg @notfelineit @frouioui