Skip to content

Temp: Pin XtraBackup version used at 2.4.24 for 5.7 tests #10194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 12 commits into from
May 3, 2022
Merged

Temp: Pin XtraBackup version used at 2.4.24 for 5.7 tests #10194

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4084bda
Pin XtraBackup version used at 2.4.24 for 5.7 tests
mattlord May 2, 2022
1b6d722
Explicitly define which clusters need XtraBackup
mattlord May 2, 2022
1b02ad4
Remove vtctlbackup_sharded_clustertest_heavy from needsXtraBackup list
mattlord May 2, 2022
e7c03a4
Look for github workflow changes in paths-filter
mattlord May 2, 2022
8ad9fef
Need to use sudo to install the deb
mattlord May 2, 2022
2c8960a
Correct errant quote placement
mattlord May 2, 2022
8eac689
Install xtrabackup deps after installing the deb file
mattlord May 2, 2022
54a7ede
Use apt install instead of dpkg
mattlord May 3, 2022
7f3716d
Actually execute the generator :facepalm:
mattlord May 3, 2022
b383755
Improve comment
mattlord May 3, 2022
701b1a4
Actions env var interpolation not working as expected...
mattlord May 3, 2022
2702706
Only include env var if xtrabackup is needed
mattlord May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/docker/cluster_test_12/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@ USER root
RUN rm -rf /vt/src/vitess.io/vitess/*
COPY . /vt/src/vitess.io/vitess

# install XtraBackup
RUN wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
RUN apt-get update
RUN apt-get install -y gnupg2
RUN dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
RUN apt-get update
RUN apt-get install -y percona-xtrabackup-24

# Set the working directory
WORKDIR /vt/src/vitess.io/vitess

Expand Down
8 changes: 0 additions & 8 deletions .github/docker/cluster_test_18/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@ USER root
RUN rm -rf /vt/src/vitess.io/vitess/*
COPY . /vt/src/vitess.io/vitess

# install XtraBackup
RUN wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
RUN apt-get update
RUN apt-get install -y gnupg2
RUN dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
RUN apt-get update
RUN apt-get install -y percona-xtrabackup-24

# Set the working directory
WORKDIR /vt/src/vitess.io/vitess

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cluster_endtoend_12.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- 'config/**'
- '.github/docker/**'
- 'bootstrap.sh'
- '.github/workflows/**'
Comment thread
mattlord marked this conversation as resolved.

- name: Build Docker Image
if: steps.changes.outputs.end_to_end == 'true'
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_13.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_17.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cluster_endtoend_18.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- 'config/**'
- '.github/docker/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Build Docker Image
if: steps.changes.outputs.end_to_end == 'true'
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_19.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/cluster_endtoend_20.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,11 +76,17 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
wget "https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb"
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo dpkg -i "percona-release_latest.$(lsb_release -sc)_all.deb"
sudo apt-get update
sudo apt-get install percona-xtrabackup-24
if [[ -n $XTRABACKUP_VERSION ]]; then
debfile="percona-xtrabackup-24_$XTRABACKUP_VERSION.$(lsb_release -sc)_amd64.deb"
wget "https://repo.percona.com/pxb-24/apt/pool/main/p/percona-xtrabackup-24/$debfile"
sudo apt install -y "./$debfile"
else
sudo apt-get install -y percona-xtrabackup-24
fi

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_21.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_22.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_24.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Installing zookeeper and consul
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_26.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/cluster_endtoend_ers_prs_newfeatures_heavy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ concurrency:

env:
LAUNCHABLE_ORGANIZATION: "vitess"
# This is used if we need to pin the xtrabackup version used in tests.
# Doing so here because 2.4.25 crashes in our 5.7 tests. See:
# https://jira.percona.com/browse/PXB-2756
# If this is NOT set then the latest version available will be used IF
# needed (see the InstallXtraBackup templating variable).
XTRABACKUP_VERSION: "2.4.24-1"
LAUNCHABLE_WORKSPACE: "vitess-app"
GITHUB_PR_HEAD_SHA: "${{ github.event.pull_request.head.sha }}"

Expand Down Expand Up @@ -36,6 +42,7 @@ jobs:
- 'tools/**'
- 'config/**'
- 'bootstrap.sh'
- '.github/workflows/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
Expand Down Expand Up @@ -69,12 +76,6 @@ jobs:
# install JUnit report formatter
go install github.com/jstemmer/go-junit-report@latest

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24

- name: Setup launchable dependencies
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
Loading