Rename drop_constraints to drop_foreign_keys on MoveTables#10017
Merged
rohit-nayak-ps merged 3 commits intovitessio:mainfrom Apr 4, 2022
Phanatic:drop-fk-constraints-move-tables
Merged
Rename drop_constraints to drop_foreign_keys on MoveTables#10017rohit-nayak-ps merged 3 commits intovitessio:mainfrom Phanatic:drop-fk-constraints-move-tables
rohit-nayak-ps merged 3 commits intovitessio:mainfrom
Phanatic:drop-fk-constraints-move-tables
Conversation
…raints on MoveTables Signed-off-by: Phani Raj <phani@planetscale.com>
Phanatic
requested review from
ajm188,
deepthi,
doeg,
mattlord,
notfelineit and
rohit-nayak-ps
as code owners
mattlord
approved these changes
Mar 31, 2022
Member
mattlord
left a comment
mattlord
left a comment
There was a problem hiding this comment.
I had one question but otherwise LGTM. Thanks!
go/vt/wrangler/materializer.go
Outdated
| createDDLAsCopy = "copy" | ||
| createDDLAsCopyDropConstraint = "copy:drop_constraint" | ||
| createDDLAsCopy = "copy" | ||
| createDDLAsCopyDropConstraint = "copy:drop_constraint" |
Member
There was a problem hiding this comment.
Do we still need this? Or do we want to support dropping FK and Check constraints at some point? Note that TableSpec.Constraints is aware of both and we seem to only care bout FK constraints here: https://github.com/vitessio/vitess/pull/10017/files#diff-9a8066951e861d9d5329f7cf03e5b70e60cbe19226c2a903efeb19c63781d8ceR1091-R1093
Member
There was a problem hiding this comment.
Can we say authoritatively that we will never need to drop all constraints? If so, we will need to run a deprecation cycle to remove copy:drop_constraint, since it is possible there are applications using this flag at the moment.
added 2 commits
April 4, 2022 15:43
Signed-off-by: Phani Raj <phani@planetscale.com>
…-move-tables Signed-off-by: Phani Raj <phani@planetscale.com>
deepthi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Phani Raj phani@planetscale.com
Description
As a follow-up to #9904, we're renaming
drop_constraintstodrop_foreign_keyson all tables when a user chooses to do so, on running MoveTables.Related Issue(s)
N/A
Checklist