Merged
Conversation
added 2 commits
March 29, 2022 06:45
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
added
Type: Bug
Type: Internal Cleanup
Component: VTAdmin
ajm188
requested review from
doeg,
notfelineit and
rohit-nayak-ps
as code owners
doeg
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed when working on #9977 that vtsql's Dial is not thread safe, which could cause multiple conns to get opened to the same vtgate rather than multiplexing via SubConns the way grpc is meant to be used. I also then extended the mutex to vtsql's Debug and both vtsql's and vtctldclientproxy's Close
Related Issue(s)
Checklist
Deployment Notes