-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rollup 3 #9870
feat: rollup 3 #9870
Conversation
Rollup 3.0 stable was released! 🥳 |
Pushed a commit to handle pure CSS chunks mapping between I also noticed a strange error when running
Can't find the source, but it's in Vitest's I also haven't fully reviewed the |
Awesome! And this made it all green!
Where are we using private properties? 🤔
What we did so far is pass empty objects (meaning no type assertions) to |
Maybe #10740 will fix this. It sounds similar. |
Ah yes that should fix it. The raw code had |
Yeah I noticed that Rollup now supports assertions too, but I think the API should have the property optional, e.g. you don't need to |
|
Looks good! It seems I checked one of the internal rollup definitions where Lukas is forcing the code to pass empty assertions to be explicit. Your change should be good on our side. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Thanks for this PR and early release of pre 4.0! |
Any feedback if you test v4-alpha.0 is appreciated @jacekkarczmarczyk! Our idea is to work with the ecosystem to fix the issues vite-ecosystem-ci uncovered above and ask for wider testing at a later stage (probably for beta.1 as usual). We are going to try to keep Vite 4 smaller than v3, so if things goes well, we should be able to release it mid-december |
Sure, I'm going to try it out today on the code from my issue here as well as on my actual project (which is yet to be converted to vite, because of that problem) |
Description
Updates Vite to Rollup 3. The main change is a new hashing algorithm:
Check out the description of that PR to understand the changes. There was an issue raised in rollup because the characters used as placeholders for the hashes of chunk file names are being encoded by Vite, preventing Rollup to replace them. See rollup/rollup#4618 (comment)
The problem was that esbuild by default runs in ascii only mode. You can see an example in this playground
We can solve this issue by using
charset: 'utf-8'
for esbuild vitejs/vite@feat/rollup-3?expand=1
#diff-6d149ac970I think that independently of Rollup 3, we should be using
utf-8
for the encoding as this is the default for HTML5 anyways.WIP, some tests are expected to fail. Pushing the branch now so we can discuss about this issue and check if the scheme used by Rollup with these non-ascii placeholders will work ok with Vite.
What is the purpose of this pull request?