Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

This PR improves perf of helper inject regex.
umd bench
iife bench

close #8738
close #8517
refs #7948
refs #8110

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 708ea77
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b46bc0c82fd40008c0706d
😎 Deploy Preview https://deploy-preview-8741--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev patak-dev merged commit 19fc7e5 into vitejs:main Jun 23, 2022
@sapphi-red sapphi-red deleted the perf/lib-improve-helper-inject-regex branch June 24, 2022 01:44
chrispcampbell added a commit to climateinteractive/SDEverywhere that referenced this pull request Jun 28, 2022
This avoids a performance regression that is reproducible when using vite 2.9.x versions >= 2.9.7.  It seems to have been fixed in 3.0.0 beta, see:
vitejs/vite#8741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants