-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use node prefix #8309
chore: use node prefix #8309
Conversation
node prefixes with vite/packages/vite/package.json Line 36 in 45dba50
So it might need to strip it in build like tsup does or bump the support version to 14.18.0. Maybe unbuild handles this already? |
We could discuss this in the next team meeting 🤔 |
For Vite core we have control of the build so it's likely possible with some grease. Otherwise, the easiest way seems to be bumping the node version, though I'm not sure if internal code cleanup justifies bumping 🤔 |
I vote to wait here, and add this to the reasons to bump (we're surely going to find more in the next months) |
I found that Vite is using |
Another trick would be to create a Rollup plugin to resolve We should probably bump to 14.14 though per sapphi's comment. EDIT: I just realized sapphi mentioned that tsup did this with an esbuild plugin too. |
Rebased this.
|
Description
Replace all node imports with
node:*
Additional context
Motivation: #8305 (comment)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).