fix: graceful rename in windows #8036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
commented
May 5, 2022
| @@ -775,8 +775,8 @@ function gracefulRename( | |||
| ) { | |||
| setTimeout(function () { | |||
| fs.stat(to, function (stater, st) { | |||
| if (stater && stater.code === 'ENOENT') gracefulRename(from, to, CB) | |||
| else cb(er) | |||
| if (stater && stater.code === 'ENOENT') fs.rename(from, to, CB) | |||
There was a problem hiding this comment.
This was a mistake when doing the translation to our code, see:
https://github.com/isaacs/node-graceful-fs/blob/1f19b0b467e4144260b397343cd60f37c5bdcfda/polyfills.js#L109
patak-dev
commented
May 5, 2022
| if (stater && stater.code === 'ENOENT') gracefulRename(from, to, CB) | ||
| else cb(er) | ||
| if (stater && stater.code === 'ENOENT') fs.rename(from, to, CB) | ||
| else CB(er) |
There was a problem hiding this comment.
This seems to be a bug on node-graceful-fs. If the code isn't 'ENOENT', it means the directory still exists and we should keep retrying. So we need to call CB. Calling cb ends the recursion returning the original error.
There was a problem hiding this comment.
Great catch. This makes sense to me too after catching the flow.
7 tasks
bluwy
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in graceful-fs rename polyfill that we based on
https://github.com/isaacs/node-graceful-fs/blob/1f19b0b467e4144260b397343cd60f37c5bdcfda/polyfills.js#L111
See context at #7939 (comment)
What is the purpose of this pull request?