Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add isolatedModules to create-vite > template-vue-ts > tsconfig #7304

Merged

Conversation

minseoksuh
Copy link
Contributor

Description

add isolatedModules to create-vite > template-vue-ts > tsconfig
https://vitejs.dev/guide/features.html#isolatedmodules

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 21990ea into vitejs:main Mar 13, 2022
@minseoksuh minseoksuh deleted the chore/template-vue-ts-isolatedModules branch March 13, 2022 06:19
@sua-dawn
Copy link

FYI: There's currently an open issue regarding isolatedModules not working with Vue's TS declarations: #5814 (created last year).
Related Vue issue: vuejs/core#1228

So currently yarn create vite vue-app-name --template vue-ts produces a project, not able to build out of the box...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants