feat(build): add option for renaming output css filename #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
reviewed
Aug 21, 2020
| cssFileName = modulesOptions!.cssFileName | ||
| } else { | ||
| cssFileName = modulesOptions!.cssFileName(staticCss) | ||
| } |
There was a problem hiding this comment.
Maybe we add a option hash on build and we should add hash for output filename (include js, css, asset) if it is true .What do you think?
There was a problem hiding this comment.
An option for hash is a good idea, a option for renaming css file too.
I could make the change :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this issue : #378 and my response.
I have added an option for renaming css output filename with two way : string or callback with return text.
Currently the css filename format is hardcoded in
buildPluginCss.ts.It allow user handle and format the filename as it want.
It's my first PR for an open-source project tell if I'have done something wrong in the workflow of developing vite and contribute to the project. I tried to follow the git commit formatting rule and the contributing guide.
The only thing I not make it's a Jest test case. It's a small option but if you want I can make one.