-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: separate version bumping and publishing on release #6879
Conversation
run: pnpm install | ||
|
||
- name: Publish package | ||
run: pnpm run ci-publish -- ${{ github.ref_name }} --dry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remove the --dry
flag
The flow looks awesome Anthony, after seeing the three clicks (because of the environment approval) and waiting at each step for the GitHub UI to respond when using dispatch, it makes a lot more sense to use the CLI as you proposed. |
Kapture.2022-02-12.at.18.39.48.mp4Added a little helper to show the git diff since the last release |
Co-authored-by: patak <[email protected]>
Workflow Changes
npm run release
script moved to top-level with an interactive prompt to select the packagenpm run release
instead of GH action dispatchingnpm run release
locally at project root of the latestmain
branchChanges Details
npm run release
moved to root, and no longer runs building and publishing.--skipBuild
option has been removed. We useprepublishOnly
hook to trigger the build before publishing.changelog
scripts in each package has been inlined in the release script to reduce duplicationnpm publish
instead ofyarn publish
since we already handle the version bumping.New Features
npm run release
will show commits between the last release of a package for the maintainer to reference