Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): Add TXT file format to assets #6265

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Conversation

boehs
Copy link
Contributor

@boehs boehs commented Dec 26, 2021

Description

There is no reason a .txt would not be an asset :)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@boehs boehs changed the title feat(import) Add TXT file format to assets feat(import): Add TXT file format to assets Dec 26, 2021
@Niputi Niputi added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 26, 2021
Niputi
Niputi previously approved these changes Dec 26, 2021
Shinigami92
Shinigami92 previously approved these changes Dec 27, 2021
@patak-dev
Copy link
Member

LGTM, but let's check this one in the next meeting, we wanted to avoid adding too many formats.

@patak-dev
Copy link
Member

We talked about the PR, and we can merge it. @boehs would you update packages/vite/client.d.ts as it is indicated in the comment about that enum? See

// ** READ THIS ** before editing `KNOWN_ASSET_TYPES`.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@boehs boehs dismissed stale reviews from Shinigami92 and Niputi via efc9b77 January 16, 2022 21:58
@boehs boehs requested a review from patak-dev January 16, 2022 21:58
@patak-dev patak-dev merged commit e87ae41 into vitejs:main Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants