-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not overwrite rollupOptions.input in dev #6025
Conversation
So with this PR, the issue that @IanVS had in storybook vite builder wouldn't have happened? #5601 (comment). @IanVS maybe you could help to review this PR? |
No, my issue was happening in production builds, so I don't think this would have had an impact. |
Is that file for testing build mode? For this PR, it is for testing dev mode. |
It is for testing anything related to build functionality. Tests are not separated per command/mode, It's okay to put them there. |
Description
fix #6020
rollupOptions.input
should not be defined in dev mode unless explicitly added by users since Vite crawls*.html
by default.Additional context
Added
dev.spec.ts
to testdev
command behavior since I can't find the respective file for the tests.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).