fix: check for Blob before creating worker URL (close #4462) #4674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4462
With server-side rendering, in my case Next.js,
Blob
isn't defined in Node.js. That causes the generated output for web workers to fail. This adds a check for the availability ofBlob
to the generated code. In its absence, the previous approach is being used. The concatenation of a long string introduces a slight inefficiency. However, I'm happy that things work again and the functionWorkerWrapper
may not even be called.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).I'm not really sure how to test this but I'm open to suggestions.