Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove usage of querystring #4342

Merged
merged 2 commits into from
Jul 21, 2021
Merged

chore: remove usage of querystring #4342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc02f2
chore: remove usage of querystring
benmccann Jul 21, 2021
710a284
chore: add missing space
Shinigami92 Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/vite/src/node/plugins/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
import { ResolvedConfig } from '../config'
import { Plugin } from '../plugin'
import { resolvePlugins } from '../plugins'
import { parse as parseUrl } from 'url'
import qs, { ParsedUrlQuery } from 'querystring'
import { parse as parseUrl, URLSearchParams } from 'url'
import { fileToUrl, getAssetHash } from './asset'
import { cleanUrl, injectQuery } from '../utils'
import Rollup from 'rollup'
import { ENV_PUBLIC_PATH } from '../constants'
import path from 'path'

function parseWorkerRequest(id: string): ParsedUrlQuery | null {
function parseWorkerRequest(id: string): Record<string,string> | null {
Shinigami92 marked this conversation as resolved.
Show resolved Hide resolved
const { search } = parseUrl(id)
if (!search) {
return null
}
return qs.parse(search.slice(1))
return Object.fromEntries(new URLSearchParams(search.slice(1)))
}

const WorkerFileId = 'worker_file'
Expand Down