Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positive needsInterop #4304

Closed
wants to merge 1 commit into from
Closed

Conversation

Mesteery
Copy link
Contributor

Fixes: #4302

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Mesteery Mesteery changed the title fix: false positive needsInterop fix: false positive needsInterop on Windows Jul 18, 2021
@Mesteery Mesteery changed the title fix: false positive needsInterop on Windows fix: false positive needsInterop Jul 18, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 18, 2021
@patak-dev
Copy link
Member

@Mesteery would you check if this is still an issue for you and resolve the conflicts in case this PR is still valid? The code has changed quite a bit in the optimizer.

@haoqunjiang
Copy link
Member

I don't fully recall the issue but the code change in this PR seems not sufficient to fix that corresponding use case.

@patak-dev
Copy link
Member

Closing as stale, and as soda said supporting that use case may require a lot more than what this PR tried to change. I'm also not convinced that the complexity to support this use case is justified

@patak-dev patak-dev closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import error in the browser and blank page in some templates (subst)
5 participants