-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow entryFileNames, chunkFileNames functions for legacy #4122
feat: allow entryFileNames, chunkFileNames functions for legacy #4122
Conversation
Thanks for the PR @umidbekk, this looks good. We should try to test this one on the current legacy playground though instead of creating a new playground, so we keep test suite run times at check. Would you try to refactor the new test there? |
Done. I also found a bug - mutation of |
Co-authored-by: Shinigami <[email protected]>
entryFileNames
and chunkFileNames
.
Description
Closes #3636
Additional context
I can't say that this solution will cover all the edge cases.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).