Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update react-refresh to 0.10.0 #4066

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

Daiz
Copy link
Contributor

@Daiz Daiz commented Jul 1, 2021

Description

This PR updates react-refresh to 0.10.0, to fix an issue where react-refresh 0.9.0 does not handle changing hook usage inside MobX observer-wrapped components well. Essentially, in this scenario, adding / removing a hook during development errors out the whole app, requiring a manual refresh. Updating react-refresh to 0.10.0 fixes the issue, so this does just that for @vitejs/plugin-react-refresh.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title Update react-refresh to 0.10.0 chore(deps): update react-refresh to 0.10.0 Jul 1, 2021
@patak-dev patak-dev merged commit fa63802 into vitejs:main Jul 1, 2021
@Daiz Daiz deleted the fix/react-refresh-update branch July 1, 2021 12:21
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants