-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-legacy): turn off babel loose mode #3406
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
<h1 id="app"></h1> | ||
<div id="env"></div> | ||
<div id="iterators"></div> | ||
<script type="module" src="./main.js"></script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (idea): Don't know if it's useful in anycase or why we need to set loose mode to
false
here, but on some places we already often have the possibility to let users decide to override such options 🤔So we may do something like
loose: options.babelTransformOptions?.loose ?? false
here, could we?Maybe there is also a better name than
babelTransformOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but perhaps it's better to wait for someone to explicitly request it? Feels like you should use loose mode only in specific situations (i.e. your own code, where you know that you don't need the stricter mode).
But since you don't know what syntax every dependency uses, it's unlikely to be a good idea to transpile your entire bundle through loose mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loose
mode equalsfalse
seems to generate much more output code and if you don't use this[...new Set()]
in any way, you are not affected by it but now forced by Vite to live with this more generated output for other stuff 🤔Also you can workaround it by not using
[...new Set()]
but[].concat(Array.from(new Set()))
+ using a polyfill forArray.from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that it generates a bigger bundle, but this code comes from Vue itself. So that's a pretty common case for Vite users, and not something you can work around like in your own code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
loose: options.babelTransformOptions?.loose ?? false
false
would be the new default, nothing against thisBut we let users that are not in this specific context decide and prevent regression in any case for them if they want to
It's downwards compatible / non-breaking with an option
And later we may also use it for e.g. let users override any options with using
{ /*...*/, ...(options.babelTransformOptions ?? {}) }
So all in all, it's just the possibility to not break anything if there are any breaking changes we currently oversee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's
babelTransformEnvOptions
?