fix: #2360. Add validation for project name.

[sunkehappy]

Project name should not contain special characters like space. So we can exit when no suitable name provided.

[rschristian]

This is totally incorrect. Please use something like validate-npm-package-name

Vite depends on resolve.exports which wouldn't pass your regex, for example.

[rschristian]

Suggested change

const projectNameRE = /^[A-Za-z0-9_-]*$/

This is no longer used.

[rschristian]

Suggested change

	const validateResult = validatePackageName(name)
	if (!validateResult.validForNewPackages) {
	console.error(
	// Only one name to be validated, so there will be only one error
	validateResult.errors.length && validateResult.errors[0]
	)
	process.exit(1)
	}
	const { errors } = validatePackageName(name);
	if (errors) {
	errors.unshift(`Invalid package name: ${name}`);
	console.error(errors.join('\n - '));
	process.exit(1);
	}

While only one name will be validated, multiple errors can in fact be returned. For example, the name 'foobar ' will result in both name cannot contain leading or trailing spaces and name can only contain URL-friendly characters being returned. Multiple errors.

[sunkehappy]

@rschristian Thank you. I correct it now.

[yyx990803]

Thanks for the PR, but validate-npm-package-name pulls in a number of extra transitive dependencies which should ideally be avoided.

Also, we should allow user to create directories with any name, we just need to make sure the name used in package.json is valid so that npm/yarn doesn't complain. see 1dbf246

[rschristian]

@yyx990803 Apologies, validate... was my suggestion, but how exactly does it pull in a number of transitive deps? The only item in the dep stack is builtins. http://npm.anvaka.com/#/view/2d/validate-npm-package-name

Fair call on allowing any directory name, though 1dbf246 is not a valid solution as npm/yarn still won't appreciate users using fs as their package name. The regex also allows me to make my package name .example, yet this too is invalid. <-- Oops, bad copy/paste to repl

I'd say it's probably beneficial to allow the lib which covers all edge cases to do this. Simpler than refining that regex and offloads the responsibility.