Skip to content

perf: only register time middleware when debug logging is enabled #23621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
Oct 1, 2026
+4 −2
Merged

perf: only register time middleware when debug logging is enabled #23621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ import {
serveRawFsMiddleware,
serveStaticMiddleware,
} from './middlewares/static'
import { timeMiddleware } from './middlewares/time'
import { isTimeDebugEnabled, timeMiddleware } from './middlewares/time'
import {
cachedTransformMiddleware,
transformMiddleware,
Expand Down Expand Up @@ -981,7 +981,7 @@ export async function _createServer(
// Pre applied internal middlewares ------------------------------------------

// request timer
if (process.env.DEBUG) {
if (isTimeDebugEnabled) {
middlewares.use(timeMiddleware(root))
}

Expand Down
2 changes: 2 additions & 0 deletions packages/vite/src/node/server/middlewares/time.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { createDebugger, prettifyUrl, timeFrom } from '../../utils'

const logTime = createDebugger('vite:time')

export const isTimeDebugEnabled: boolean = logTime !== undefined

export function timeMiddleware(root: string): Connect.NextHandleFunction {
// Keep the named function. The name is visible in debug logs via `DEBUG=connect:dispatcher ...`
return function viteTimeMiddleware(req, res, next) {
Expand Down
Loading