Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/vite/src/node/__tests__/utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
getServerUrlByHost,
injectQuery,
isFileReadable,
isInNodeModules,
isParentDirectory,
mergeWithDefaults,
normalizePath,
Expand Down Expand Up @@ -83,6 +84,29 @@ describe('bareImportRE', () => {
})
})

describe('isInNodeModules', () => {
test('should detect node_modules path segments', () => {
expect(isInNodeModules('/project/node_modules/foo/index.js')).toBe(true)
expect(isInNodeModules('node_modules/foo/index.js')).toBe(true)
expect(
isInNodeModules(
'/project/node_modules/.pnpm/foo@1/node_modules/foo/i.js',
),
).toBe(true)
expect(isInNodeModules('C:\\project\\node_modules\\foo\\index.js')).toBe(
true,
)
expect(isInNodeModules('/project/node_modules')).toBe(true)
})

test('should not match node_modules as part of a directory name', () => {
expect(isInNodeModules('/project/node_modules_bug/src/main.js')).toBe(false)
expect(isInNodeModules('/project/my_node_modules/src/main.js')).toBe(false)
expect(isInNodeModules('/project/src/node_modules.js')).toBe(false)
expect(isInNodeModules('C:\\node_modules_bug\\src\\main.js')).toBe(false)
})
})

describe('isParentDirectory', () => {
const cases = {
'/parent': {
Expand Down
4 changes: 3 additions & 1 deletion packages/vite/src/node/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,10 @@ export function isNodeBuiltin(id: string): boolean {
return nodeBuiltins.includes(id)
}

const inNodeModulesRE = /(?:^|[\\/])node_modules(?:[\\/]|$)/

export function isInNodeModules(id: string): boolean {
return id.includes('node_modules')
return inNodeModulesRE.test(id)
}

export function moduleListContains(
Expand Down
Loading