Skip to content

refactor: use named regex constants over inline literals #22964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 3 commits into from
Aug 17, 2026
Merged

refactor: use named regex constants over inline literals #22964

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5516a0
refactor(config): use named regex constants over inline literals
btea Jul 17, 2026
6f9ec3f
Merge branch 'main' into refactor/use-named-regex-const
btea Jul 21, 2026
4537a9d
refactor: update
btea Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vite/src/node/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import {
DEFAULT_SERVER_MAIN_FIELDS,
ENV_ENTRY,
FS_PREFIX,
OPTIMIZABLE_ENTRY_RE,
} from './constants'
import { resolveEnvironmentPlugins } from './plugin'
import type {
Expand Down Expand Up @@ -2606,7 +2607,7 @@ async function bundleConfigFile(
{
name: 'inject-file-scope-variables',
transform: {
filter: { id: /\.[cm]?[jt]s$/ },
filter: { id: OPTIMIZABLE_ENTRY_RE },
Comment thread
bluwy marked this conversation as resolved.
Resolved
handler(code, id) {
let injectValues =
`const ${dirnameVarName} = ${JSON.stringify(path.dirname(id))};` +
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/nativeConfigCompat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ export function createNativeConfigCompatPlugin(
transform: {
filter: {
id: {
include: /\.[cm]?[jt]sx?$/,
include: jsTsExtRE,
// exclude rolldown runtime
exclude: /^\0/,
},
Expand Down