fix(client): ignore forward console send failures (fix #22407)#22409
Closed
cyphercodes wants to merge 1 commit into
Closed
fix(client): ignore forward console send failures (fix #22407)#22409cyphercodes wants to merge 1 commit into
cyphercodes wants to merge 1 commit into
Conversation
Member
|
Thanks, but I created a separate PR (#22450) as I thought we should log the unexpected errors and also the tests added here can be flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22407.
When forward console reports logs or unhandled errors after the client transport disconnects,
transport.send()rejects. If that rejection is left unhandled, the forward consoleunhandledrejectionlistener can try to forward the send failure too and enter a loop.This change routes forwarded console payloads through a shared helper that catches send failures and drops them when the transport is no longer available.
Tests
pnpm --filter vite build-bundlepnpm run test-unit packages/vite/src/shared/__tests__/forwardConsole.spec.tspnpm exec eslint packages/vite/src/shared/forwardConsole.ts packages/vite/src/shared/__tests__/forwardConsole.spec.ts --concurrency autopnpm --filter vite build-typespnpm --filter vite typecheckgit diff --check