refactor: remove unnecessary async

eslint.config.js

@@ -172,7 +172,7 @@ export default defineConfig(
       '@typescript-eslint/prefer-nullish-coalescing': 'off',
       '@typescript-eslint/prefer-optional-chain': 'off',
       '@typescript-eslint/prefer-string-starts-ends-with': 'off', // prefer indexed access for better performance
-      '@typescript-eslint/require-await': 'off',
+      '@typescript-eslint/require-await': 'off', // does not handle inferred required async functions well
       '@typescript-eslint/restrict-template-expressions': 'off', // does not matter for us
       '@typescript-eslint/unbound-method': 'off',
 

packages/vite/rolldown.config.ts

@@ -181,7 +181,7 @@ function enableSourceMapsInWatchModePlugin(): Plugin {
 function writeTypesPlugin(): Plugin {
   return {
     name: 'write-types',
-    async writeBundle() {
+    writeBundle() {
       if (this.meta.watchMode) {
         writeFileSync(
           'dist/node/index.d.ts',

packages/vite/src/node/build.ts

@@ -502,10 +502,10 @@ export function resolveBuildEnvironmentOptions(
   return resolved
 }
 
-export async function resolveBuildPlugins(config: ResolvedConfig): Promise<{
+export function resolveBuildPlugins(config: ResolvedConfig): {
   pre: Plugin[]
   post: Plugin[]
-}> {
+} {
   const isBuild = config.command === 'build'
   return {
     pre: [

packages/vite/src/node/config.ts

@@ -2370,7 +2370,7 @@ async function bundleConfigFile(
         name: 'externalize-deps',
         resolveId: {
           filter: { id: /^[^.#].*/ },
-          async handler(id, importer, { kind }) {
+          handler(id, importer, { kind }) {
             if (!importer || path.isAbsolute(id) || isNodeBuiltin(id)) {
               return
             }

packages/vite/src/node/optimizer/optimizer.ts

@@ -540,7 +540,7 @@ export function createDepsOptimizer(
     })
   }
 
-  async function rerun() {
+  function rerun() {
     // debounce time to wait for new missing deps finished, issue a new
     // optimization of deps (both old and newly found) once the previous
     // optimizeDeps processing is finished

packages/vite/src/node/optimizer/rolldownDepPlugin.ts

@@ -316,7 +316,7 @@ export function rolldownDepPlugin(
         filter: {
           code: assetImportMetaUrlRE,
         },
-        async handler(code, id) {
+        handler(code, id) {
           let s: MagicString | undefined
           const re = new RegExp(assetImportMetaUrlRE)
           const cleanString = stripLiteral(code)

packages/vite/src/node/plugins/clientInjections.ts

@@ -37,7 +37,7 @@ export function clientInjectionsPlugin(config: ResolvedConfig): Plugin {
     async buildStart() {
       injectConfigValues = await createClientConfigValueReplacer(config)
     },
-    async transform(code, id) {
+    transform(code, id) {
       const ssr = this.environment.config.consumer === 'server'
       const cleanId = cleanUrl(id)
       if (cleanId === normalizedClientEntry || cleanId === normalizedEnvEntry) {
@@ -50,7 +50,7 @@ export function clientInjectionsPlugin(config: ResolvedConfig): Plugin {
         const nodeEnv =
           this.environment.config.define?.['process.env.NODE_ENV'] ||
           JSON.stringify(process.env.NODE_ENV || config.mode)
-        return await replaceDefine(this.environment, code, id, {
+        return replaceDefine(this.environment, code, id, {
           'process.env.NODE_ENV': nodeEnv,
           'global.process.env.NODE_ENV': nodeEnv,
           'globalThis.process.env.NODE_ENV': nodeEnv,

packages/vite/src/node/plugins/css.ts

@@ -339,7 +339,7 @@ export function cssPlugin(config: ResolvedConfig): Plugin {
       filter: {
         id: CSS_LANGS_RE,
       },
-      async handler(id) {
+      handler(id) {
         if (urlRE.test(id)) {
           if (isModuleCSSRequest(id)) {
             throw new Error(
@@ -1182,7 +1182,7 @@ export function cssAnalysisPlugin(config: ResolvedConfig): Plugin {
           exclude: [commonjsProxyRE, SPECIAL_QUERY_RE],
         },
       },
-      async handler(_, id) {
+      handler(_, id) {
         const { moduleGraph } = this.environment as DevEnvironment
         const thisModule = moduleGraph.getModuleById(id)
 
@@ -1904,7 +1904,7 @@ const viteHashUpdateMarkerRE = /\/\*\$vite\$:\d+\*\//
 async function finalizeCss(css: string, config: ResolvedConfig) {
   // hoist external @imports and @charset to the top of the CSS chunk per spec (#1845 and #6333)
   if (css.includes('@import') || css.includes('@charset')) {
-    css = await hoistAtRules(css)
+    css = hoistAtRules(css)
   }
   if (config.build.cssMinify) {
     css = await minifyCSS(css, config, false)
@@ -2310,7 +2310,7 @@ const atImportRE =
 const atCharsetRE =
   /@charset(?:\s*(?:"(?:[^"]|(?<=\\)")*"|'(?:[^']|(?<=\\)')*').*?|[^;]*);/g
 
-export async function hoistAtRules(css: string): Promise<string> {
+export function hoistAtRules(css: string): string {
   const s = new MagicString(css)
   const cleanCss = emptyCssComments(css)
   let match: RegExpExecArray | null

packages/vite/src/node/plugins/define.ts

@@ -132,7 +132,7 @@ export function definePlugin(config: ResolvedConfig): Plugin {
     name: 'vite:define',
 
     transform: {
-      async handler(code, id) {
+      handler(code, id) {
         if (this.environment.config.consumer === 'client') {
           // for dev we inject actual global defines in the vite client to
           // avoid the transform cost. see the `clientInjection` and
@@ -157,22 +157,22 @@ export function definePlugin(config: ResolvedConfig): Plugin {
         pattern.lastIndex = 0
         if (!pattern.test(code)) return
 
-        const result = await replaceDefine(this.environment, code, id, define)
+        const result = replaceDefine(this.environment, code, id, define)
         return result
       },
     },
   }
 }
 
-export async function replaceDefine(
+export function replaceDefine(
   environment: Environment,
   code: string,
   id: string,
   define: Record<string, string>,
-): Promise<{
+): {
   code: string
   map: ReturnType<typeof transformSync>['map'] | null
-}> {
+} {
   const result = transformSync(id, code, {
     lang: 'js',
     sourceType: 'module',

packages/vite/src/node/plugins/esbuild.ts

@@ -537,10 +537,10 @@ export function getTSConfigResolutionCache(
   return cache
 }
 
-export async function reloadOnTsconfigChange(
+export function reloadOnTsconfigChange(
   server: ViteDevServer,
   changedFile: string,
-): Promise<void> {
+): void {
   // any tsconfig.json that's added in the workspace could be closer to a code file than a previously cached one
   // any json file in the tsconfig cache could have been used to compile ts
   if (changedFile.endsWith('.json')) {

packages/vite/src/node/plugins/index.ts

@@ -49,7 +49,7 @@ export async function resolvePlugins(
   const isBundled = config.isBundled
   const isWorker = config.isWorker
   const buildPlugins = isBundled
-    ? await (await import('../build')).resolveBuildPlugins(config)
+    ? (await import('../build')).resolveBuildPlugins(config)
     : { pre: [], post: [] }
   const { modulePreload } = config.build
 

packages/vite/src/node/plugins/license.ts

@@ -45,7 +45,7 @@ export function licensePlugin(): Plugin {
   return {
     name: 'vite:license',
 
-    async generateBundle(_, bundle) {
+    generateBundle(_, bundle) {
       const licenseOption = this.environment.config.build.license
       if (licenseOption === false) return
 

packages/vite/src/node/plugins/wasm.ts

@@ -113,7 +113,7 @@ export default ${wasmHelperCode}
         env.config.consumer === 'server'
           ? {
               filter: { code: wasmInitUrlRE },
-              async handler(code, chunk, opts, meta) {
+              handler(code, chunk, opts, meta) {
                 const toRelativeRuntime =
                   createToImportMetaURLBasedRelativeRuntime(
                     opts.format,

packages/vite/src/node/plugins/worker.ts

@@ -515,7 +515,7 @@ export function webWorkerPlugin(config: ResolvedConfig): Plugin {
 
     transform: {
       filter: { id: workerFileRE },
-      async handler(raw, id) {
+      handler(raw, id) {
         const workerFileMatch = workerFileRE.exec(id)
         if (workerFileMatch) {
           // if import worker by worker constructor will have query.type

packages/vite/src/node/server/environment.ts

@@ -161,7 +161,7 @@ export class DevEnvironment extends BaseEnvironment {
 
     this.hot.on(
       'vite:invalidate',
-      async ({ path, message, firstInvalidatedBy }, client) => {
+      ({ path, message, firstInvalidatedBy }, client) => {
         this.invalidateModule(
           {
             path,
@@ -401,7 +401,7 @@ function setupOnCrawlEnd(): CrawlEndFinder {
       callCrawlEndIfIdleAfterMs,
     )
   }
-  async function callOnCrawlEndWhenIdle() {
+  function callOnCrawlEndWhenIdle() {
     if (cancelled || registeredIds.size > 0) return
     onCrawlEndPromiseWithResolvers.resolve()
   }

packages/vite/src/node/ssr/ssrTransform.ts

@@ -43,10 +43,10 @@ export async function ssrTransform(
   return ssrTransformScript(code, inMap, url, originalCode)
 }
 
-async function ssrTransformJSON(
+function ssrTransformJSON(
   code: string,
   inMap: SourceMap | { mappings: '' } | null,
-): Promise<TransformResult> {
+): TransformResult {
   return {
     code: code.replace('export default', `${ssrModuleExportsKey}.default =`),
     map: inMap,

packages/vite/src/shared/moduleRunnerTransport.ts

@@ -270,7 +270,7 @@ export const createWebSocketModuleRunnerTransport = (options: {
   return {
     async connect({ onMessage, onDisconnection }) {
       const socket = options.createConnection()
-      socket.addEventListener('message', async ({ data }) => {
+      socket.addEventListener('message', ({ data }) => {
         onMessage(JSON.parse(data))
       })
 
@@ -285,7 +285,7 @@ export const createWebSocketModuleRunnerTransport = (options: {
             },
             { once: true },
           )
-          socket.addEventListener('close', async () => {
+          socket.addEventListener('close', () => {
             if (!isOpened) {
               reject(new Error('WebSocket closed without opened.'))
               return