Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vite/src/node/server/middlewares/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ export function transformMiddleware(
const sourcemapPath = url.startsWith(FS_PREFIX)
? fsPathFromId(url)
: normalizePath(path.resolve(server.config.root, url.slice(1)))
// url may contain relative path that may resolve outside of the optimized deps directory
if (!depsOptimizer.isOptimizedDepFile(sourcemapPath)) {
return next()
}
try {
const map = JSON.parse(
await fsp.readFile(sourcemapPath, 'utf-8'),
Expand Down
15 changes: 15 additions & 0 deletions playground/fs-serve/__tests__/fs-serve.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,21 @@ describe.runIf(isServe)('invalid request', () => {
target: path.posix.join('/@fs/', root, 'root/src/dummy.crt/') + '.',
status: 'HTTP/1.1 403 Forbidden',
},
{
name: 'denied optimize deps sourcemap handler',
target:
path.posix.join('/@fs/', root) +
'/node_modules/.vite/deps/../../../unsafe.map',
status: 'HTTP/1.1 403 Forbidden',
},
{
name: 'denied backslash optimize deps sourcemap handler',
target:
path.posix.join('/@fs/', root) +
'/node_modules/.vite/deps/..\\..\\..\\unsafe.map',
status: isWindows ? 'HTTP/1.1 403 Forbidden' : 'HTTP/1.1 200 OK',
content: isWindows ? undefined : 'Cache-Control: no-cache',
},
{
name: 'HTML outside root with relative path',
target: '/../unsafe.html',
Expand Down
3 changes: 3 additions & 0 deletions playground/fs-serve/unsafe.map
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"key": "unsafe"
}
Loading