Skip to content

perf: early return in getLocalhostAddressIfDiffersFromDNS when DNS order is verbatim #22151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 1 commit into from
Apr 7, 2026
Merged

perf: early return in getLocalhostAddressIfDiffersFromDNS when DNS order is verbatim #22151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions packages/vite/src/node/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,17 +922,21 @@ export function unique<T>(arr: T[]): T[] {
* Even if defaultResultOrder is `ipv4first`, `dns.lookup` result maybe same.
* For example, when IPv6 is not supported on that machine/network.
*/
export async function getLocalhostAddressIfDiffersFromDNS(): Promise<
string | undefined
> {
const [nodeResult, dnsResult] = await Promise.all([
export function getLocalhostAddressIfDiffersFromDNS():
| Promise<string | undefined>
| undefined {
if (dns.getDefaultResultOrder() === 'verbatim') {
return undefined
}
return Promise.all([
dns.lookup('localhost'),
dns.lookup('localhost', { verbatim: true }),
])
const isSame =
nodeResult.family === dnsResult.family &&
nodeResult.address === dnsResult.address
return isSame ? undefined : nodeResult.address
]).then(([nodeResult, dnsResult]) => {
const isSame =
nodeResult.family === dnsResult.family &&
nodeResult.address === dnsResult.address
return isSame ? undefined : nodeResult.address
})
}

export function diffDnsOrderChange(
Expand Down
Loading