Skip to content

fix: preserve manifest metadata for same-basename CSS entries#22054

Closed
raashish1601 wants to merge 4 commits into
vitejs:mainfrom
raashish1601:contributor-12/vite-22013
Closed

fix: preserve manifest metadata for same-basename CSS entries#22054
raashish1601 wants to merge 4 commits into
vitejs:mainfrom
raashish1601:contributor-12/vite-22013

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

  • key emitted CSS entry metadata by the original entry path when available instead of the lossy chunk basename
  • reuse the same key when replacing pure CSS entry placeholders so manifest bookkeeping resolves the right emitted asset
  • add a build regression for two CSS entry points with the same basename in different directories

Fixes #22013.

Testing

  • corepack pnpm exec vitest run packages/vite/src/node/__tests__/build.spec.ts -t "manifest keeps same-basename css entries independent"
  • corepack pnpm exec eslint packages/vite/src/node/plugins/css.ts packages/vite/src/node/__tests__/build.spec.ts
  • git diff --check

@sapphi-red
Copy link
Copy Markdown
Member

Thanks, but I think #22039's approach is better

@sapphi-red sapphi-red closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS entry points sharing the same basename in different directories produce incorrect cross-linked css dependencies in manifest

2 participants