Skip to content

fix(ssr): ssrTransform incorrectly rewrites meta identifier inside import.meta when a binding named meta exists #22019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 2 commits into from
Mar 25, 2026
+17 −0
Merged

fix(ssr): ssrTransform incorrectly rewrites meta identifier inside import.meta when a binding named meta exists #22019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
348d1f1
Initial plan
Copilot Mar 25, 2026
3080764
fix: ssrTransform fails to transform import.meta when there is import…
Copilot Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,18 @@ test('import.meta', async () => {
).toMatchInlineSnapshot(`"console.log(__vite_ssr_import_meta__.url)"`)
})

test('import.meta with imported variable named meta', async () => {
expect(
await ssrTransformSimpleCode(
`import { meta } from './meta';\nconsole.log(import.meta.url, \`Hello, \${meta}!\`)`,
),
).toMatchInlineSnapshot(`
"const __vite_ssr_import_0__ = await __vite_ssr_import__("./meta", {"importedNames":["meta"]});

console.log(__vite_ssr_import_meta__.url, \`Hello, \${__vite_ssr_import_0__.meta}!\`)"
`)
})

test('dynamic import', async () => {
const result = await ssrTransformSimple(
`export const i = () => import('./foo')`,
Expand Down
5 changes: 5 additions & 0 deletions packages/vite/src/node/ssr/ssrTransform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,11 @@ function isRefIdentifier(
return false
}

// meta property (e.g. import.meta)
if (parent.type === 'MetaProperty') {
return false
}

// export { id } from "lib"
// export * as id from "lib"
if (
Expand Down
Loading