Skip to content

fix(dev): return "502 Bad Gateway" on proxy failures instead of 500 #21652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 4 commits into from
Feb 17, 2026
Merged

fix(dev): return "502 Bad Gateway" on proxy failures instead of 500 #21652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d0dd0c
Initial plan
Copilot Feb 17, 2026
ed46557
Change proxy error status code from 500 to 502 Bad Gateway
Copilot Feb 17, 2026
889abbb
Use foo.invalid instead of localhost:9608 for proxy error test
Copilot Feb 17, 2026
174c59e
chore: update
sapphi-red Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/src/node/server/middlewares/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export function proxyMiddleware(
)
if (!res.headersSent && !res.writableEnded) {
res
.writeHead(500, {
.writeHead(502, {
'Content-Type': 'text/plain',
})
.end()
Expand Down
7 changes: 6 additions & 1 deletion playground/proxy-bypass/__tests__/proxy-bypass.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test, vi } from 'vitest'
import { browserLogs, page, serverLogs } from '~utils'
import { browserLogs, isServe, page, serverLogs, viteTestUrl } from '~utils'

test('proxy-bypass', async () => {
await vi.waitFor(() => {
Expand All @@ -17,3 +17,8 @@ test('async-proxy-bypass-with-error', async () => {
expect(serverLogs.join('\n')).toContain('bypass error')
})
})

test.runIf(isServe)('proxy error returns 502', async () => {
const res = await fetch(viteTestUrl + '/proxyError')
expect(res.status).toBe(502)
})
3 changes: 3 additions & 0 deletions playground/proxy-bypass/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ export default defineConfig({
return false
},
},
'/proxyError': {
target: 'http://foo.invalid',
},
'/asyncResponse': {
bypass: async (_, res) => {
await timeout(4)
Expand Down
Loading