Skip to content

perf(ssr): skip circular import check for already-evaluated modules #21632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 3 commits into from
Feb 16, 2026
Merged

perf(ssr): skip circular import check for already-evaluated modules #21632

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88a85a5
perf(ssr): skip circular import check for already-evaluated modules
Feb 13, 2026
8c0fd31
docs: add isCircularImport benchmark script
Feb 13, 2026
bd20409
chore: move benchmark script and convert it to use the actual moduler…
sapphi-red Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/vite/src/module-runner/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,12 @@ export class ModuleRunner {

if (importee) importers.add(importee)

// check circular dependency
// fast path: already evaluated modules can't deadlock
if (mod.evaluated && mod.promise) {
return this.processImport(await mod.promise, meta, metadata)
}

// check circular dependency (only for modules still being evaluated)
if (
callstack.includes(moduleId) ||
this.isCircularModule(mod) ||
Expand All @@ -207,7 +212,7 @@ export class ModuleRunner {
}

try {
// cached module
// cached module (in-progress, not yet evaluated)
if (mod.promise)
return this.processImport(await mod.promise, meta, metadata)

Expand Down