Skip to content

fix(hmr): wait for import.meta.hot.prune callbacks to complete before running other HMRs #20698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
+8 −6
Merged

fix(hmr): wait for import.meta.hot.prune callbacks to complete before running other HMRs #20698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f54d53
fix(hmr): wait for `import.meta.hot.prune` callbacks to complete befo…
sapphi-red Aug 29, 2025
437dc1c
fix: return promise properly
sapphi-red Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/vite/src/shared/hmr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,14 @@ export class HMRClient {
if (disposer) return disposer(this.dataMap.get(path))
}),
)
paths.forEach((path) => {
const fn = this.pruneMap.get(path)
if (fn) {
fn(this.dataMap.get(path))
}
})
await Promise.all(
paths.map((path) => {
const fn = this.pruneMap.get(path)
if (fn) {
return fn(this.dataMap.get(path))
}
}),
)
}

protected warnFailedUpdate(err: Error, path: string | string[]): void {
Expand Down
Loading