Skip to content

fix(types): add a global interface for Worker #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

fix(types): add a global interface for Worker #20243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2029d70
Add a global interface for Worker
samchungy Jun 19, 2025
939436f
copy aws-sdk comment
samchungy Jun 19, 2025
5ed712f
disable eslint
samchungy Jun 19, 2025
43cc992
chore: remove WebWorker from lib in `tsconfig.check.json` to catch re…
sapphi-red Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/tsconfig.check.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"target": "ES2020",
"moduleResolution": "node16",
"module": "Node16",
"lib": ["ES2020", "WebWorker"], // ES2020 is very conservative check for client types, could be bumped if needed
"lib": ["ES2020"], // ES2020 is very conservative check for client types, could be bumped if needed
"types": [], // Avoid checking unrelated node_modules types
"noEmit": true,
"strict": true,
Expand Down
10 changes: 10 additions & 0 deletions packages/vite/types/importGlob.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ export interface ImportGlobOptions<

export type GeneralImportGlobOptions = ImportGlobOptions<boolean, string>

/**
* Declare Worker in case DOM is not added to the tsconfig lib causing
* Worker interface is not defined. For developers with DOM lib added,
* the Worker interface will be merged correctly.
*/
declare global {
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
interface Worker {}
}

export interface KnownAsTypeMap {
raw: string
url: string
Expand Down