Skip to content

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented May 13, 2025

Description

Tanstack team (@schiller-manuel) reported the issue about Tailwind' use of config.createResolver, which breaks since Tanstack start has environment named "server" instead of "ssr" TanStack/router#4132.

It looks like the comment is only in the implementation, but not in ResolvedConfig types, so people don't notice. I copied the same jsdoc to the type.

/**
* createResolver is deprecated. It only works for the client and ssr
* environments. The `aliasOnly` option is also not being used any more
* Plugins should move to createIdResolver(environment) instead.
* create an internal resolver to be used in special scenarios, e.g.
* optimizer & handling css @imports
*/
createResolver(options) {

@hi-ogawa hi-ogawa marked this pull request as ready for review May 13, 2025 00:48
sapphi-red
sapphi-red previously approved these changes May 13, 2025
Co-authored-by: Bjorn Lu <[email protected]>
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 14, 2025
@sapphi-red sapphi-red merged commit d101d64 into vitejs:main May 14, 2025
16 checks passed
@hi-ogawa hi-ogawa deleted the chore-deprecate-resolvedConfig-createResolver branch May 14, 2025 10:00
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants