Skip to content

refactor: remove deprecated env api properties #19986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 2 commits into from
May 16, 2025
+0 −20
Merged

refactor: remove deprecated env api properties #19986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e22e2f
refactor!: remove `HotUpdateOptions.environment`
sapphi-red May 2, 2025
509c56b
refactor!: remove `PartialEnvironment.options`
sapphi-red May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/vite/src/node/baseEnvironment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@ export class PartialEnvironment {

config: ResolvedConfig & ResolvedEnvironmentOptions

/**
* @deprecated use environment.config instead
**/
get options(): ResolvedEnvironmentOptions {
return this._options
}

logger: Logger

/**
Expand Down
6 changes: 0 additions & 6 deletions packages/vite/src/node/optimizer/scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ export function devToScanEnvironment(
getTopLevelConfig() {
return environment.getTopLevelConfig()
},
/**
* @deprecated use environment.config instead
**/
get options() {
return environment.options
},
get config() {
return environment.config
},
Expand Down
7 changes: 0 additions & 7 deletions packages/vite/src/node/server/hmr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ export interface HotUpdateOptions {
modules: Array<EnvironmentModuleNode>
read: () => string | Promise<string>
server: ViteDevServer

/**
* @deprecated use this.environment in the hotUpdate hook instead
**/
environment: DevEnvironment
}

export interface HmrContext {
Expand Down Expand Up @@ -447,8 +442,6 @@ export async function handleHMRUpdate(
const options = {
...contextMeta,
modules: [...mods],
// later on hotUpdate will be called for each runtime with a new HotUpdateOptions
environment,
}
hotMap.set(environment, { options })
}
Expand Down