Skip to content

fix(css): inline css correctly for double quote use strict #19590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
Merged

fix(css): inline css correctly for double quote use strict #19590

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95f6d31
fix(css): inline css correctly for double quote use strict
underfin Mar 6, 2025
7c8a966
chore: update
patak-dev Mar 6, 2025
c7bd103
chore: it's strict
sapphi-red Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,12 +939,19 @@ export function cssPostPlugin(config: ResolvedConfig): Plugin {
`document.head.appendChild(${style});`
let injectionPoint
const wrapIdx = code.indexOf('System.register')
const singleQuoteUseStrict = `'use strict';`
const doubleQuoteUseStrict = `"use strict";`
if (wrapIdx >= 0) {
const executeFnStart = code.indexOf('execute:', wrapIdx)
injectionPoint = code.indexOf('{', executeFnStart) + 1
} else if (code.includes(singleQuoteUseStrict)) {
injectionPoint =
code.indexOf(singleQuoteUseStrict) + singleQuoteUseStrict.length
} else if (code.includes(doubleQuoteUseStrict)) {
injectionPoint =
code.indexOf(doubleQuoteUseStrict) + doubleQuoteUseStrict.length
} else {
const insertMark = "'use strict';"
injectionPoint = code.indexOf(insertMark) + insertMark.length
throw new Error('Injection point for inlined CSS not found')
}
s ||= new MagicString(code)
s.appendRight(injectionPoint, injectCode)
Expand Down