Skip to content

fix(css): stabilize css module hashes with lightningcss in dev mode #19481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged

fix(css): stabilize css module hashes with lightningcss in dev mode #19481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02d1e07
fix(css): stabilize css module hashes with lightningcss in dev mode
azat-io Feb 21, 2025
56f96ce
test: add tests for scoped name generation for lightningcss
azat-io Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/vite/src/node/__tests__/plugins/css.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,25 @@ composes: bar from '@/css/bar.module.css';
const css = `\
.foo {
color: red;
}`
const result1 = await transform(css, '/foo.module.css') // server
const result2 = await transform(css, '/foo.module.css?direct') // client
expect(result1.code).toBe(result2.code)
})

test('custom generateScopedName with lightningcss', async () => {
const { transform } = await createCssPluginTransform({
configFile: false,
css: {
modules: {
generateScopedName: 'custom__[hash:base64:5]',
},
transformer: 'lightningcss',
},
})
const css = `\
.foo {
color: red;
}`
const result1 = await transform(css, '/foo.module.css') // server
const result2 = await transform(css, '/foo.module.css?direct') // client
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3297,7 +3297,7 @@ async function compileLightningCSS(
const deps = new Set<string>()
// replace null byte as lightningcss treats that as a string terminator
// https://github.com/parcel-bundler/lightningcss/issues/874
const filename = id.replace('\0', NULL_BYTE_PLACEHOLDER)
const filename = removeDirectQuery(id).replace('\0', NULL_BYTE_PLACEHOLDER)

let res: LightningCssTransformAttributeResult | LightningCssTransformResult
try {
Expand Down