Skip to content

fix: default empty server proxy prevents starting http2 server #18788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 3 commits into from
Nov 27, 2024
Merged

fix: default empty server proxy prevents starting http2 server #18788

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b776d8
fix(vite): default empty server `proxy` prevents starting http2 server
userquin Nov 26, 2024
1850b10
chore: add comment
sapphi-red Nov 27, 2024
2ce0820
chore: use undefined
sapphi-red Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,7 @@ export const serverConfigDefaults = Object.freeze({
host: 'localhost',
https: undefined,
open: false,
Comment thread
sapphi-red marked this conversation as resolved.
proxy: {},
// proxy
Comment thread
sapphi-red marked this conversation as resolved.
Outdated
cors: true,
headers: {},
// hmr
Expand Down