Skip to content

fix(module-runner): make evaluator optional #18672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 2 commits into from
Nov 19, 2024
Merged

fix(module-runner): make evaluator optional #18672

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3567aff
fix(module-runner): make evaluator optional
sheremet-va Nov 14, 2024
e3ce47e
chore: remove not used new Evaluator()
sheremet-va Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vite/src/module-runner/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {
import { hmrLogger, silentConsole } from './hmrLogger'
import { createHMRHandler } from './hmrHandler'
import { enableSourceMapSupport } from './sourcemap/index'
import { ESModulesEvaluator } from './esmEvaluator'

interface ModuleRunnerDebugger {
(formatter: unknown, ...args: unknown[]): void
Expand Down Expand Up @@ -61,7 +62,7 @@ export class ModuleRunner {

constructor(
public options: ModuleRunnerOptions,
public evaluator: ModuleEvaluator,
public evaluator: ModuleEvaluator = new ESModulesEvaluator(),
private debug?: ModuleRunnerDebugger,
) {
const root = this.options.root
Expand Down