Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm catalog protocol #17642

Closed
wants to merge 1 commit into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Jul 9, 2024

Copy link

stackblitz bot commented Jul 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea btea changed the title workflow: use pnpm catalog protocol chore: use pnpm catalog protocol Jul 9, 2024
@zyyv
Copy link
Contributor

zyyv commented Jul 10, 2024

I saw in the documentation that pnpm update is not supported. Does this mean that subsequent updates can only be done manually or the version is locked?

@btea
Copy link
Collaborator Author

btea commented Jul 10, 2024

@zyyv Yes, it is true at the moment and can only be updated manually. Maybe in the future, pnpm update will be able to edit the pnpm-workspace.yaml file.
pnpm/pnpm#8286

@patak-dev patak-dev added the p2-to-be-discussed Enhancement under consideration (priority) label Jul 13, 2024
@bluwy
Copy link
Member

bluwy commented Jul 15, 2024

I don't quite see any benefit using catalogs now. Are we hitting any issues before that this fixes it? If not, I'd say we should wait until so before making this change.

@btea
Copy link
Collaborator Author

btea commented Jul 15, 2024

No, there is nothing wrong with the current way of writing. The advantage of catalog is that it can manage the same dependencies used by multiple sub-packages together.

As shown in the code, we don't extract many reused dependencies now, so it doesn't matter whether we change them or not.

I just wanted to try this feature out. 😀

@bluwy
Copy link
Member

bluwy commented Jul 24, 2024

I'll close this for now as there isn't a need to use it yet. We can revisit again when we do. Thanks for the PR!

@bluwy bluwy closed this Jul 24, 2024
@btea btea deleted the workflow/use-pnpm-catalog-protocol branch July 24, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-to-be-discussed Enhancement under consideration (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants