fix: make server type less restrictive (fix #17627)
#17628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
reviewed
Jul 15, 2024
There was a problem hiding this comment.
The changes looks fine to me, though I'm not sure if we need tests for this. I think it's fine to omit them.
I've not seen it mentioned, but I believe the inconvenient typing is because of this?
vite/packages/vite/src/node/server/index.ts
Line 224 in d454c8c
The https possibility interferes when passing the server.httpServer.
|
@bluwy Exactly, that's where the inconvenience stems from. Would you like me to remove the test I added? |
|
Yes please, and appreciate the effort making the test! If another maintainer prefers keeping the test still, I don't mind, but I think at the moment it's rare to break it again. |
bluwy
approved these changes
Jul 16, 2024
patak-dev
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #17627 by making the type of
serverandserverless restrictive.