feat: add resolveBuiltUrl hook
#1675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2021
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Jan 23, 2021
...and any local non-module `<script>` tags. This is especially useful in combination with vitejs#1675.
|
This makes a lot of sense -- for anyone that wants to do 0 downtime deploys, uploading the assets to some shared global store is super key. 👍 |
aleclarson
force-pushed
the
feat/resolveBuiltUrl
branch
from
053d1d8
to
b270481
Compare
Shinigami92
reviewed
Mar 19, 2021
Shinigami92
added
the
p2-nice-to-have
|
Note: This depends on #3032 for CSS urls to be supported. |
|
This is also very relevant for existing projects that might not want static assets handling. |
For rewriting the public URLs of static assets.
aleclarson
force-pushed
the
feat/resolveBuiltUrl
branch
from
d735562
to
f325977
Compare
Shinigami92
reviewed
Apr 20, 2021
Shinigami92
approved these changes
Apr 20, 2021
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Oct 4, 2021
… in the facade module This commit allows for assets in ./public/ to have their URLs transformed at build time, making plugins like vite-plugin-public and vite-plugin-rehost possible. Depends on vitejs#1675
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Oct 4, 2021
… in the facade module This commit allows for assets in ./public/ to have their URLs transformed at build time, making plugins like vite-plugin-public and vite-plugin-rehost possible. Depends on vitejs#1675
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Oct 4, 2021
… in the facade module This commit allows for assets in ./public/ to have their URLs transformed at build time, making plugins like vite-plugin-public and vite-plugin-rehost possible. Depends on vitejs#1675
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Oct 4, 2021
… in the facade module This commit allows for assets in ./public/ to have their URLs transformed at build time, making plugins like vite-plugin-public and vite-plugin-rehost possible. Depends on vitejs#1675
|
For reference, this PR was discussed and approved in a team meeting. We need tests to be able to merge it. If someone wants this in, please PR a test case to this branch. |
4 tasks
9 tasks
|
I think this is supported through experimental.resolveBuiltUrl now, when that is out of experimental, we can revisit if it makes sense to be a new hook. I also don't quite understand the usecase of hashing public files. Public files are copied as-is, if assets needs to be hashed, they should be out of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rewriting the public URLs of static assets.
Used by vite-plugin-rehost and vite-plugin-public.