-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vite): add help usage #16390
Conversation
- help argument will be used as "--help" and by default it is false
- i want to find a way to decouple the text from the code
|
- Using alias to define template and help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting nits, otherwise a nice addition to me!
- To improve maintainability, the help message has been moved to a separate file. - Implemented the suggestions provided in the pull request.
Yeah I did try that but to do so and others, it slows creeps in as a lot of code compared to hardcoding. So I leaned directly to the simplest way for now. |
Yeah that was also the part where I threw my hand and went for the simpler path instead 😄 It's hard to sort that one with a specific hardcoding too. |
Description
closes #16374
![image](https://private-user-images.githubusercontent.com/75655486/321501129-b5790331-bacf-48c0-9828-28737bc06c4e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MDE4MDAsIm5iZiI6MTcyNTYwMTUwMCwicGF0aCI6Ii83NTY1NTQ4Ni8zMjE1MDExMjktYjU3OTAzMzEtYmFjZi00OGMwLTk4MjgtMjg3MzdiYzA2YzRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA1NDUwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlODVjMGIzNWYzZDEwMTRjMjA3ZmUyMzdjZjIwYTY1N2ZmNzgyZDlkZGU4OWJjY2JiYzFlNzhlNzM5ZDI4NTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ocJCvAtXS-NFN1N3D5qGaOBZVTaJkgUo8Hwk8HmD85k)