Skip to content

fix: public files map will be updated on add/unlink in windows #15317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: public files map will be updated on add/unlink in windows #15317

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ab269a
fix: public files map will be updated on add/unlink in windows
jmlee2k Dec 11, 2023
776c386
precomputed normalized public dir
jmlee2k Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,10 +645,11 @@ export async function _createServer(
file = normalizePath(file)
await container.watchChange(file, { event: isUnlink ? 'delete' : 'create' })

if (publicFiles && config.publicDir && file.startsWith(config.publicDir)) {
publicFiles[isUnlink ? 'delete' : 'add'](
file.slice(config.publicDir.length),
)
if (config.publicDir && publicFiles) {
const publicDir = normalizePath(config.publicDir)
Copy link
Member

@patak-dev patak-dev Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the fix 🙏🏼

Would you extract this as const normalizedPublicDir = normalizePath(config.publicDir) out of the function so it is precomputed?

Copy link
Contributor Author

@jmlee2k jmlee2k Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done!

Copy link
Member

@patak-dev patak-dev Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

if (file.startsWith(publicDir)) {
publicFiles[isUnlink ? 'delete' : 'add'](file.slice(publicDir.length))
}
}
await handleFileAddUnlink(file, server, isUnlink)
await onHMRUpdate(file, true)
Expand Down