Skip to content

fix: server.headers after restart in middleware mode #14905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: server.headers after restart in middleware mode #14905

merged 1 commit into from
Nov 8, 2023

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 8, 2023

Description

Alternative to #14895

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 8, 2023
patak-dev
patak-dev approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should merge this one 👍🏼

@patak-dev patak-dev merged commit f9ce9db into vitejs:main Nov 8, 2023
@patak-dev patak-dev mentioned this pull request Nov 8, 2023
Closed
4 tasks
@sapphi-red sapphi-red deleted the fix/server-headers-after-restart-in-middleware branch November 8, 2023 08:50
@patak-dev patak-dev mentioned this pull request Nov 9, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees

No one assigned

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @patak-dev