Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-vite): add eslint.config.js to React templates #12860

Merged
merged 17 commits into from
Jul 31, 2024
+110 −59
Merged

feat(create-vite): add eslint.config.js to React templates #12860

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
eb9fb0e
rebased for new eslint flat config
Nov 11, 2023
63e4416
add ignore patterns
Nov 11, 2023
37e1a06
fix lint issue
Nov 11, 2023
6057fe5
ignore the config file itself
smeng9 Apr 6, 2024
c1bffda
incorporate changes in #13750
smeng9 Apr 6, 2024
297690f
add eslint compat layer
Jun 18, 2024
2e43ed9
fix linter
Jun 18, 2024
a13e87b
nits
ArnaudBarre Jun 18, 2024
a5a5012
peer dependency override
smeng9 Jun 19, 2024
08c6f71
Merge branch 'main' into react-template-eslint
smeng9 Jun 30, 2024
fb28bf9
Merge branch 'main' into react-template-eslint
smeng9 Jul 3, 2024
fa813b8
Merge branch 'main' into pr/smeng9/12860
bluwy Jul 30, 2024
a69d7b4
chore: use canary
bluwy Jul 30, 2024
d6089bc
docs: update readme [skip ci]
bluwy Jul 30, 2024
da21981
use tseslint
ArnaudBarre Jul 30, 2024
b54b3f0
docs: update readme [skip ci]
bluwy Jul 30, 2024
9f6a689
fix config & doc
ArnaudBarre Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions packages/create-vite/template-react-ts/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

33 changes: 33 additions & 0 deletions packages/create-vite/template-react-ts/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { fixupPluginRules } from '@eslint/compat'
import js from '@eslint/js'
import globals from 'globals'
import reactHooks from 'eslint-plugin-react-hooks'
import reactRefresh from 'eslint-plugin-react-refresh'
import tsParser from '@typescript-eslint/parser'
import tsPlugin from '@typescript-eslint/eslint-plugin'

export default [
bluwy marked this conversation as resolved.
Show resolved Hide resolved
{
files: ['**/*.{ts,tsx}'],
ignores: ['dist'],
languageOptions: {
ecmaVersion: 2020,
globals: globals.browser,
parser: tsParser,
},
plugins: {
'react-hooks': fixupPluginRules(reactHooks),
'react-refresh': reactRefresh,
'@typescript-eslint': tsPlugin,
},
rules: {
...js.configs.recommended.rules,
...tsPlugin.configs.recommended.rules,
...reactHooks.configs.recommended.rules,
'react-refresh/only-export-components': [
'warn',
{ allowConstantExport: true },
],
},
},
]
9 changes: 6 additions & 3 deletions packages/create-vite/template-react-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,26 @@
"scripts": {
"dev": "vite",
"build": "tsc -b && vite build",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"lint": "eslint . --max-warnings 0",
"preview": "vite preview"
},
"dependencies": {
"react": "^18.3.1",
"react-dom": "^18.3.1"
},
"devDependencies": {
"@eslint/compat": "^1.1.0",
"@eslint/js": "^9.5.0",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@typescript-eslint/eslint-plugin": "^7.13.1",
"@typescript-eslint/parser": "^7.13.1",
"@vitejs/plugin-react": "^4.3.1",
"eslint": "^8.57.0",
"eslint": "^9.5.0",
"eslint-plugin-react-hooks": "^4.6.2",
"eslint-plugin-react-refresh": "^0.4.7",
"typescript": "^5.2.2",
"globals": "^15.6.0",
"typescript": "^5.4.5",
"vite": "^5.3.1"
}
}
21 changes: 0 additions & 21 deletions packages/create-vite/template-react/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

39 changes: 39 additions & 0 deletions packages/create-vite/template-react/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { fixupPluginRules } from '@eslint/compat'
import js from '@eslint/js'
import globals from 'globals'
import react from 'eslint-plugin-react'
import reactHooks from 'eslint-plugin-react-hooks'
import reactRefresh from 'eslint-plugin-react-refresh'

export default [
{
files: ['**/*.{js,jsx}'],
ignores: ['dist'],
languageOptions: {
ecmaVersion: 2020,
globals: globals.browser,
parserOptions: {
ecmaVersion: 'latest',
ecmaFeatures: { jsx: true },
sourceType: 'module',
},
},
settings: { react: { version: '18.3' } },
plugins: {
react: fixupPluginRules(react),
'react-hooks': fixupPluginRules(reactHooks),
'react-refresh': reactRefresh,
},
rules: {
...js.configs.recommended.rules,
...react.configs.recommended.rules,
...react.configs['jsx-runtime'].rules,
...reactHooks.configs.recommended.rules,
'react/jsx-no-target-blank': 'off',
'react-refresh/only-export-components': [
'warn',
{ allowConstantExport: true },
],
},
},
]
7 changes: 5 additions & 2 deletions packages/create-vite/template-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,24 @@
"scripts": {
"dev": "vite",
"build": "vite build",
"lint": "eslint . --ext js,jsx --report-unused-disable-directives --max-warnings 0",
"lint": "eslint . --max-warnings 0",
"preview": "vite preview"
},
"dependencies": {
"react": "^18.3.1",
"react-dom": "^18.3.1"
},
"devDependencies": {
"@eslint/compat": "^1.1.0",
"@eslint/js": "^9.5.0",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.3.1",
"eslint": "^8.57.0",
"eslint": "^9.5.0",
"eslint-plugin-react": "^7.34.2",
"eslint-plugin-react-hooks": "^4.6.2",
"eslint-plugin-react-refresh": "^0.4.7",
"globals": "^15.6.0",
"vite": "^5.3.1"
}
}